Bug 151284

Summary: Clean referencing the options object in the graphics benchmark
Product: WebKit Reporter: Said Abou-Hallawa <sabouhallawa>
Component: AnimationsAssignee: Said Abou-Hallawa <sabouhallawa>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, dino, rniwa, simon.fraser
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Said Abou-Hallawa
Reported 2015-11-13 16:49:59 PST
Currently the Benchmark object holds two members for the options: Benchmark.options and Benchmark._options. I think one of them we added by mistake assuming the Benchmark does not hold a reference to the options. Also the Animator references the options through the reference it holds to the Benchmark.
Attachments
Patch (12.80 KB, patch)
2015-11-13 17:24 PST, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Said Abou-Hallawa
Comment 1 2015-11-13 17:24:10 PST
Created attachment 265520 [details] Patch
WebKit Commit Bot
Comment 2 2015-11-16 15:22:19 PST
Comment on attachment 265520 [details] Patch Clearing flags on attachment: 265520 Committed r192491: <http://trac.webkit.org/changeset/192491>
WebKit Commit Bot
Comment 3 2015-11-16 15:22:22 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.