Bug 151284

Summary:

Clean referencing the options object in the graphics benchmark

Product:

WebKit

Reporter:

Said Abou-Hallawa <sabouhallawa>

Component:

Animations

Assignee:

Said Abou-Hallawa <sabouhallawa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, commit-queue, dino, rniwa, simon.fraser

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Said Abou-Hallawa 2015-11-13 16:49:59 PST

Currently the Benchmark object holds two members for the options: Benchmark.options and Benchmark._options. I think one of them we added by mistake assuming the Benchmark does not hold a reference to the options. Also the Animator references the options through the reference it holds to the Benchmark.

Comment 1 Said Abou-Hallawa 2015-11-13 17:24:10 PST

Created attachment 265520 [details]
Patch

Comment 2 WebKit Commit Bot 2015-11-16 15:22:19 PST

Comment on attachment 265520 [details]
Patch

Clearing flags on attachment: 265520

Committed r192491: <http://trac.webkit.org/changeset/192491>

Comment 3 WebKit Commit Bot 2015-11-16 15:22:22 PST

All reviewed patches have been landed.  Closing bug.