| Summary: | WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction calls an std::function after it's been moved from | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ryuan Choi <ryuan.choi> | ||||
| Component: | WebKit2 | Assignee: | Ryuan Choi <ryuan.choi> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, mcatanzaro | ||||
| Priority: | P2 | ||||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| See Also: | https://bugzilla.redhat.com/show_bug.cgi?id=1269778 | ||||||
| Attachments: |
|
||||||
|
Description
Ryuan Choi
2015-11-12 23:38:06 PST
Created attachment 265472 [details]
Patch
Comment on attachment 265472 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=265472&action=review > Source/WebKit2/ChangeLog:9 > + Like r188287, calling an empty std::function results in a std::bad_function_call > + exception being thrown when sendSync is failed. Fix looks fine. Why no regression test, though? (In reply to comment #2) > Comment on attachment 265472 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=265472&action=review > > > Source/WebKit2/ChangeLog:9 > > + Like r188287, calling an empty std::function results in a std::bad_function_call > > + exception being thrown when sendSync is failed. > > Fix looks fine. Why no regression test, though? I don't have idea to make a test case that sendSync is failed, although EFL test case(test_ewk2_view) sometimes raises this exception. Comment on attachment 265472 [details] Patch Clearing flags on attachment: 265472 Committed r192496: <http://trac.webkit.org/changeset/192496> All reviewed patches have been landed. Closing bug. |