Bug 151248

Summary: WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction calls an std::function after it's been moved from
Product: WebKit Reporter: Ryuan Choi <ryuan.choi>
Component: WebKit2Assignee: Ryuan Choi <ryuan.choi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, mcatanzaro
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugzilla.redhat.com/show_bug.cgi?id=1269778
Attachments:
Description Flags
Patch none

Ryuan Choi
Reported 2015-11-12 23:38:06 PST
Like Bug 147873, it may generate std::bad_function_call
Attachments
Patch (2.25 KB, patch)
2015-11-13 00:08 PST, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryuan Choi
Comment 1 2015-11-13 00:08:15 PST
Created attachment 265472 [details] Patch
Darin Adler
Comment 2 2015-11-14 18:53:16 PST
Comment on attachment 265472 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=265472&action=review > Source/WebKit2/ChangeLog:9 > + Like r188287, calling an empty std::function results in a std::bad_function_call > + exception being thrown when sendSync is failed. Fix looks fine. Why no regression test, though?
Ryuan Choi
Comment 3 2015-11-15 04:05:12 PST
(In reply to comment #2) > Comment on attachment 265472 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=265472&action=review > > > Source/WebKit2/ChangeLog:9 > > + Like r188287, calling an empty std::function results in a std::bad_function_call > > + exception being thrown when sendSync is failed. > > Fix looks fine. Why no regression test, though? I don't have idea to make a test case that sendSync is failed, although EFL test case(test_ewk2_view) sometimes raises this exception.
WebKit Commit Bot
Comment 4 2015-11-16 16:27:01 PST
Comment on attachment 265472 [details] Patch Clearing flags on attachment: 265472 Committed r192496: <http://trac.webkit.org/changeset/192496>
WebKit Commit Bot
Comment 5 2015-11-16 16:27:05 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.