Bug 151247

Summary: [EFL] Fix wrong test case for window_create since r192196
Product: WebKit Reporter: Ryuan Choi <ryuan.choi>
Component: WebKit EFLAssignee: Ryuan Choi <ryuan.choi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, lucas.de.marchi
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 145924    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Description Ryuan Choi 2015-11-12 22:00:21 PST 
There is typos in test cases in Bug 145924 and those typos hide the bugs.

I will fix typos and separate test case to fix the bug which makes test case fail.
Comment 1 Ryuan Choi 2015-11-12 22:20:04 PST 
Created attachment 265468 [details]
Patch
Comment 2 Gyuyoung Kim 2015-11-12 22:40:25 PST 
Comment on attachment 265468 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=265468&action=review

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:-746
> -    if (!ewk_view_title_get(s_newWindowObject), "Page1")

It's weird this code has been working.

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:793
> +TEST_F(EWK2ViewTestNewWindowWithMultipleProcesses, ewk_view_create_window2)

I think it would be good to use more meaningful name rather than window2.
Comment 3 Ryuan Choi 2015-11-12 23:04:09 PST 
Created attachment 265469 [details]
Patch
Comment 4 WebKit Commit Bot 2015-11-12 23:57:03 PST 
Comment on attachment 265469 [details]
Patch

Clearing flags on attachment: 265469

Committed r192410: <http://trac.webkit.org/changeset/192410>
Comment 5 WebKit Commit Bot 2015-11-12 23:57:08 PST 
All reviewed patches have been landed.  Closing bug.