Bug 151247

Summary: [EFL] Fix wrong test case for window_create since r192196
Product: WebKit Reporter: Ryuan Choi <ryuan.choi>
Component: WebKit EFLAssignee: Ryuan Choi <ryuan.choi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, lucas.de.marchi
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 145924    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Ryuan Choi
Reported 2015-11-12 22:00:21 PST
There is typos in test cases in Bug 145924 and those typos hide the bugs. I will fix typos and separate test case to fix the bug which makes test case fail.
Attachments
Patch (4.79 KB, patch)
2015-11-12 22:20 PST, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
Patch (4.85 KB, patch)
2015-11-12 23:04 PST, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryuan Choi
Comment 1 2015-11-12 22:20:04 PST
Created attachment 265468 [details] Patch
Gyuyoung Kim
Comment 2 2015-11-12 22:40:25 PST
Comment on attachment 265468 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=265468&action=review > Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:-746 > - if (!ewk_view_title_get(s_newWindowObject), "Page1") It's weird this code has been working. > Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:793 > +TEST_F(EWK2ViewTestNewWindowWithMultipleProcesses, ewk_view_create_window2) I think it would be good to use more meaningful name rather than window2.
Ryuan Choi
Comment 3 2015-11-12 23:04:09 PST
Created attachment 265469 [details] Patch
WebKit Commit Bot
Comment 4 2015-11-12 23:57:03 PST
Comment on attachment 265469 [details] Patch Clearing flags on attachment: 265469 Committed r192410: <http://trac.webkit.org/changeset/192410>
WebKit Commit Bot
Comment 5 2015-11-12 23:57:08 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.