Bug 151238

Summary:

Style checker script should not mark cq-

Product:

WebKit

Reporter:

Geoffrey Garen <ggaren>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED INVALID

Severity:

Normal

CC:

ap, commit-queue, keith_miller, lforschler, mark.lam, msaboff, saam

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
try it out	none
try it out	none
try it out	none

Geoffrey Garen

Reported 2015-11-12 17:13:54 PST

Because the style checker is not very reliable, and it will get in the way of broader commit queue usage.

Attachments
try it out (448 bytes, text/plain) 2015-11-12 17:24 PST, Geoffrey Garen	no flags	Details
try it out (448 bytes, patch) 2015-11-12 17:24 PST, Geoffrey Garen	no flags	Details Formatted Diff Diff
try it out (506 bytes, patch) 2015-11-12 17:28 PST, Geoffrey Garen	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Geoffrey Garen

Comment 1 2015-11-12 17:24:17 PST

Created attachment 265455 [details] try it out

Geoffrey Garen

Comment 2 2015-11-12 17:24:56 PST

Created attachment 265456 [details] try it out

Geoffrey Garen

Comment 3 2015-11-12 17:28:11 PST

Created attachment 265458 [details] try it out

WebKit Commit Bot

Comment 4 2015-11-12 17:30:12 PST

Attachment 265458 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/heap/Heap.cpp:123: this_has_underscores is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 1 in 1 files If any of these errors are false positives, please file a bug against check-webkit-style.

Geoffrey Garen

Comment 5 2015-11-12 17:31:26 PST

Looks like this is already policy.

Note You need to log in before you can comment on or make changes to this bug.