Modern IDB: Pipe through cursor functions from client to server

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[Brady Eidson]

Modern IDB: Pipe through cursor functions from client to server

The result of all requests will always be an error for now.

[Brady Eidson]

(In reply to comment #0)
> Modern IDB: Pipe through cursor functions from client to server
> 
> The result of all requests will always be an error for now.

Until https://bugs.webkit.org/show_bug.cgi?id=151196 is resolved

[Brady Eidson]

Created attachment 265437 [details]
Patch v1

[Alex Christensen]

Comment on attachment 265437 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=265437&action=review

> Source/WebCore/Modules/indexeddb/client/IDBCursorImpl.cpp:49
> +    , m_source(adoptRef(*IDBAny::create(objectStore).leakRef()))

can you use wtf::move here, or just *IDBAny::create(objectStore), or make IDBAny::create return a Ref?

> Source/WebCore/Modules/indexeddb/client/IDBCursorImpl.cpp:56
> +    , m_source(adoptRef(*IDBAny::create(index).leakRef()))

same.

[Brady Eidson]

(In reply to comment #3)
> Comment on attachment 265437 [details]
> Patch v1
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=265437&action=review
> 
> > Source/WebCore/Modules/indexeddb/client/IDBCursorImpl.cpp:49
> > +    , m_source(adoptRef(*IDBAny::create(objectStore).leakRef()))
> 
> can you use wtf::move here, or just *IDBAny::create(objectStore), or make
> IDBAny::create return a Ref?

The first two, no.
The third, yes.

> 
> > Source/WebCore/Modules/indexeddb/client/IDBCursorImpl.cpp:56
> > +    , m_source(adoptRef(*IDBAny::create(index).leakRef()))
> 
> same.

Same.

[Brady Eidson]

Created attachment 265441 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 265441 [details]
Patch for landing

Clearing flags on attachment: 265441

Committed r192396: <http://trac.webkit.org/changeset/192396>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.