Bug 151191

Summary: Support building configuration Production of DumpRenderTree and WebKitTestRunner for iOS
Product: WebKit Reporter: Daniel Bates <dbates>
Component: Tools / TestsAssignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, ap, dburkart, ddkilzer, lforschler
Priority: P2    
Version: WebKit Local Build   
Hardware: Mac   
OS: OS X 10.11   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Daniel Bates
Reported 2015-11-12 07:56:18 PST
We should support building production configuration of DumpRenderTree and WebKitTestRunner for iOS Simulator just as we do for Mac.
Attachments
Patch (15.78 KB, patch)
2015-11-12 07:57 PST, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Patch (6.79 KB, patch)
2015-11-12 08:46 PST, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Patch (10.10 KB, patch)
2015-11-12 10:18 PST, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2015-11-12 07:57:04 PST
Created attachment 265393 [details] Patch
Daniel Bates
Comment 2 2015-11-12 08:46:17 PST
Created attachment 265399 [details] Patch
Dana Burkart
Comment 3 2015-11-12 09:31:09 PST
Comment on attachment 265399 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=265399&action=review > Tools/DumpRenderTree/mac/DumpRenderTreeMain.mm:37 > +int main(int, char*[]) For consistency, shouldn't this method signature match the one above? Like: int main(int argc, const char *argv[]) > Tools/WebKitTestRunner/mac/main.mm:68 > +int main(int, char*[]) Ditto.
Daniel Bates
Comment 4 2015-11-12 10:08:33 PST
(In reply to comment #3) > Comment on attachment 265399 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=265399&action=review > > > Tools/DumpRenderTree/mac/DumpRenderTreeMain.mm:37 > > +int main(int, char*[]) > > For consistency, shouldn't this method signature match the one above? Like: > > int main(int argc, const char *argv[]) > Will fix. > > Tools/WebKitTestRunner/mac/main.mm:68 > > +int main(int, char*[]) > > Ditto. Will fix.
Daniel Bates
Comment 5 2015-11-12 10:18:06 PST
Created attachment 265405 [details] Patch
Daniel Bates
Comment 6 2015-11-12 12:02:30 PST
Comment on attachment 265405 [details] Patch Clearing flags on attachment: 265405 Committed r192375: <http://trac.webkit.org/changeset/192375>
Daniel Bates
Comment 7 2015-11-12 12:02:33 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.