Bug 151186 – Fix build failure due to missing NeverDestroyed.h include after r192169

• Component: New Bugs
• Status: RESOLVED FIXED

[Csaba Osztrogonác]

http://trac.webkit.org/changeset/192169 broke the --minimal build:

../../Source/WebCore/rendering/RenderCombineText.cpp: In member function ‘void WebCore::RenderCombineText::combineText()’:
../../Source/WebCore/rendering/RenderCombineText.cpp:185:71: error: variable ‘WTF::NeverDestroyed<WTF::String> objectReplacementCharacterString’ has initializer but incomplete type
         static NeverDestroyed<String> objectReplacementCharacterString(&objectReplacementCharacter, 1);
                                                                       ^
ninja: build stopped: subcommand failed.


The normal build works fine, because some #if guarded header includes NeverDestroyed.h,
but RenderCombineText.cpp shouldn't rely on this transitive dependency.

[Csaba Osztrogonác]

Created attachment 265381 [details]
Patch

[Darin Adler]

Comment on attachment 265381 [details]
Patch

In general we *do* rely on transitive dependencies all the time, but if it’s platform specific, then a fix like this is fine.

[WebKit Commit Bot]

Comment on attachment 265381 [details]
Patch

Clearing flags on attachment: 265381

Committed r192368: <http://trac.webkit.org/changeset/192368>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.