Bug 151186

Summary: Fix build failure due to missing NeverDestroyed.h include after r192169
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: New BugsAssignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, esprehn+autocc, glenn, kondapallykalyan, mmaxfield
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 150986    
Attachments:
Description Flags
Patch none

Description Csaba Osztrogonác 2015-11-12 03:47:09 PST
http://trac.webkit.org/changeset/192169 broke the --minimal build:

../../Source/WebCore/rendering/RenderCombineText.cpp: In member function ‘void WebCore::RenderCombineText::combineText()’:
../../Source/WebCore/rendering/RenderCombineText.cpp:185:71: error: variable ‘WTF::NeverDestroyed<WTF::String> objectReplacementCharacterString’ has initializer but incomplete type
         static NeverDestroyed<String> objectReplacementCharacterString(&objectReplacementCharacter, 1);
                                                                       ^
ninja: build stopped: subcommand failed.


The normal build works fine, because some #if guarded header includes NeverDestroyed.h,
but RenderCombineText.cpp shouldn't rely on this transitive dependency.
Comment 1 Csaba Osztrogonác 2015-11-12 03:53:23 PST
Created attachment 265381 [details]
Patch
Comment 2 Darin Adler 2015-11-12 09:33:40 PST
Comment on attachment 265381 [details]
Patch

In general we *do* rely on transitive dependencies all the time, but if it’s platform specific, then a fix like this is fine.
Comment 3 WebKit Commit Bot 2015-11-12 10:21:34 PST
Comment on attachment 265381 [details]
Patch

Clearing flags on attachment: 265381

Committed r192368: <http://trac.webkit.org/changeset/192368>
Comment 4 WebKit Commit Bot 2015-11-12 10:21:39 PST
All reviewed patches have been landed.  Closing bug.