| Summary: | [JSC] Add a comment explaining the opcode suffixes on x86 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Benjamin Poulain <benjamin> | ||||
| Component: | New Bugs | Assignee: | Benjamin Poulain <benjamin> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | ||||||
| Priority: | P2 | ||||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Benjamin Poulain
2015-11-11 19:22:04 PST
Created attachment 265352 [details]
Patch
Comment on attachment 265352 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=265352&action=review I've wondered about the EvGv suffixes, too. > Source/JavaScriptCore/assembler/X86Assembler.h:181 > + // The most commons argument types are: common > Source/JavaScriptCore/assembler/X86Assembler.h:185 > + // The most commons sizes are: common > Source/JavaScriptCore/assembler/X86Assembler.h:187 > + // -z: 32bits in both 32bits and 64bits mode. Common for immediate values. 32bit and 64bit mode Committed r192348: <http://trac.webkit.org/changeset/192348> |