Bug 151171

Summary: [JSC] Do not generate an Add when adding a zero immediate to something
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: New BugsAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fpizlo, keith_miller, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews112 for mac-yosemite
none
Patch none

Benjamin Poulain
Reported 2015-11-11 18:07:05 PST
[JSC] Do not generate an Add when adding a zero immedate to something
Attachments
Patch (8.59 KB, patch)
2015-11-11 18:07 PST, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews112 for mac-yosemite (803.16 KB, application/zip)
2015-11-11 19:09 PST, Build Bot 		no flags
Details
Patch (11.46 KB, patch)
2015-11-12 17:44 PST, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2015-11-11 18:07:35 PST
Created attachment 265343 [details] Patch
Geoffrey Garen
Comment 2 2015-11-11 18:27:38 PST
Comment on attachment 265343 [details] Patch r=me
Build Bot
Comment 3 2015-11-11 19:09:34 PST
Comment on attachment 265343 [details] Patch Attachment 265343 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/417081 New failing tests: js/regress/ArrayBuffer-Int32Array-byteOffset.html
Build Bot
Comment 4 2015-11-11 19:09:36 PST
Created attachment 265349 [details] Archive of layout-test-results from ews112 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-yosemite Platform: Mac OS X 10.10.5
Benjamin Poulain
Comment 5 2015-11-12 17:44:39 PST
Created attachment 265459 [details] Patch
Geoffrey Garen
Comment 6 2015-11-12 17:55:18 PST
Comment on attachment 265459 [details] Patch r=me
WebKit Commit Bot
Comment 7 2015-11-12 22:13:12 PST
Comment on attachment 265459 [details] Patch Clearing flags on attachment: 265459 Committed r192409: <http://trac.webkit.org/changeset/192409>
WebKit Commit Bot
Comment 8 2015-11-12 22:13:16 PST
All reviewed patches have been landed. Closing bug.
Filip Pizlo
Comment 9 2016-02-04 14:51:25 PST
This change is invalid. add32() is also used to zero-extend the value. I don't think it makes sense to try to audit all of the places that rely on add32() for zero extension, there are probably many of them.
Note You need to log in before you can comment on or make changes to this bug.