Bug 151159

Summary: Add ability to insert probes in LLVM IR that we generate.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
the patch. none

Mark Lam
Reported 2015-11-11 15:17:09 PST
This is done by inserting a stackmap intrinsic and emitting the probe there.
Attachments
the patch. (6.51 KB, patch)
2015-11-11 15:22 PST, Mark Lam 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2015-11-11 15:22:05 PST
Created attachment 265322 [details] the patch.
WebKit Commit Bot
Comment 2 2015-11-11 15:24:33 PST
Attachment 265322 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:9401: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/JavaScriptCore/ftl/FTLInlineCacheDescriptor.h:181: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/JavaScriptCore/ftl/FTLInlineCacheDescriptor.h:190: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 3 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Geoffrey Garen
Comment 3 2015-11-11 15:53:15 PST
Comment on attachment 265322 [details] the patch. r=me
WebKit Commit Bot
Comment 4 2015-11-11 16:41:12 PST
Comment on attachment 265322 [details] the patch. Clearing flags on attachment: 265322 Committed r192334: <http://trac.webkit.org/changeset/192334>
WebKit Commit Bot
Comment 5 2015-11-11 16:41:14 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.