Summary: | Web Inspector: inspector settings should not be shared between different inspection levels | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | BJ Burg <bburg> | ||||||||
Component: | Web Inspector | Assignee: | BJ Burg <bburg> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Bug Depends on: | 151573 | ||||||||||
Bug Blocks: | 147066 | ||||||||||
Attachments: |
|
Description
BJ Burg
2015-11-11 13:14:37 PST
On investigation, settings are set to local storage immediately, but there is no namespacing for different inspection levels. Retitling to fix this bug first. There seems to be a separate bug about breakpoints not being saved to persistent storage in many cases (especially Inspector^2 when using Cmd-Q). I'll investigate that further after we use separate settings per inspection level. Created attachment 266090 [details]
WIP
Created attachment 266100 [details]
How WK1 inspection levels are computed
I attached a drawing that shows how InspectorFrontendClientLocal computes inspection levels. The WK2 case is, surprisingly, much simpler to reason about.
Created attachment 266102 [details]
Proposed Fix
Comment on attachment 266102 [details] Proposed Fix Clearing flags on attachment: 266102 Committed r192756: <http://trac.webkit.org/changeset/192756> All reviewed patches have been landed. Closing bug. |