|Summary:||Web Inspector: inspector settings should not be shared between different inspection levels|
|Product:||WebKit||Reporter:||Brian Burg <bburg>|
|Component:||Web Inspector||Assignee:||Brian Burg <bburg>|
|Severity:||Normal||CC:||bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer|
|Version:||WebKit Nightly Build|
|Bug Depends on:||151573|
Description Brian Burg 2015-11-11 13:14:37 PST
SUMMARY: AFAIK, local storage settings (WebInspector.Setting) are only saved to local storage when the inspector closes. It's really easy to blow away your breakpoints if the inspector crashes. We should save this more often. Perhaps we can coalesce to do this every few seconds after a setting change.
Comment 2 Brian Burg 2015-11-22 22:30:25 PST
On investigation, settings are set to local storage immediately, but there is no namespacing for different inspection levels. Retitling to fix this bug first. There seems to be a separate bug about breakpoints not being saved to persistent storage in many cases (especially Inspector^2 when using Cmd-Q). I'll investigate that further after we use separate settings per inspection level.
Comment 4 Brian Burg 2015-11-23 14:55:57 PST
Created attachment 266100 [details] How WK1 inspection levels are computed I attached a drawing that shows how InspectorFrontendClientLocal computes inspection levels. The WK2 case is, surprisingly, much simpler to reason about.
Comment 6 WebKit Commit Bot 2015-11-23 18:49:59 PST
Comment on attachment 266102 [details] Proposed Fix Clearing flags on attachment: 266102 Committed r192756: <http://trac.webkit.org/changeset/192756>
Comment 7 WebKit Commit Bot 2015-11-23 18:50:02 PST
All reviewed patches have been landed. Closing bug.