Bug 151148

Summary: Assignment to new.target should be an early error
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, fpizlo, ggaren, gskachkov, keith_miller, mark.lam, msaboff, oliver, saam, sukolsak, ysuzuki
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
mark.lam: review+
patch for landing none

Comment 1 Saam Barati 2016-03-09 23:48:53 PST
Created attachment 273545 [details]
patch
Comment 2 WebKit Commit Bot 2016-03-09 23:51:12 PST
Attachment 273545 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/parser/Parser.cpp:3043:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/parser/Parser.cpp:4012:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/parser/Parser.cpp:4024:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/parser/Parser.cpp:4038:  Multi line control clauses should use braces.  [whitespace/braces] [4]
Total errors found: 4 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Mark Lam 2016-03-10 00:06:34 PST
Comment on attachment 273545 [details]
patch

r=me
Comment 4 Saam Barati 2016-03-10 00:08:52 PST
Created attachment 273546 [details]
patch for landing

thanks for the review.
Here is an updated patch that I will land later.
It updates the stress/new-target.js file because that
test no longer parses!
Comment 5 Saam Barati 2016-03-10 11:42:48 PST
landed in:
http://trac.webkit.org/changeset/197947