Bug 151122

Summary: Use different pixel formats for displays that support them
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, mitz, simon.fraser
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
For EWS
none
For EWS none

Description Simon Fraser (smfr) 2015-11-10 16:48:37 PST
Use different pixel formats for dipslays that support them
Comment 1 Simon Fraser (smfr) 2015-11-10 16:51:53 PST
Created attachment 265246 [details]
Patch
Comment 2 WebKit Commit Bot 2015-11-10 16:53:24 PST
Attachment 265246 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/cocoa/IOSurface.h:43:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/graphics/cocoa/IOSurface.h:44:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/graphics/cocoa/IOSurface.h:45:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 3 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Tim Horton 2015-11-10 16:59:51 PST
Comment on attachment 265246 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=265246&action=review

> Source/WebCore/ChangeLog:3
> +        Use different pixel formats for dipslays that support them

dipslays
Comment 4 Simon Fraser (smfr) 2015-11-10 17:06:54 PST
Created attachment 265249 [details]
For EWS
Comment 5 WebKit Commit Bot 2015-11-10 17:08:50 PST
Attachment 265249 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/cocoa/IOSurface.h:43:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/graphics/cocoa/IOSurface.h:44:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/graphics/cocoa/IOSurface.h:45:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 3 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Simon Fraser (smfr) 2015-11-10 17:10:55 PST
Created attachment 265252 [details]
For EWS
Comment 7 WebKit Commit Bot 2015-11-10 17:12:51 PST
Attachment 265252 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/cocoa/IOSurface.h:43:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/graphics/cocoa/IOSurface.h:44:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/graphics/cocoa/IOSurface.h:45:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 3 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 Simon Fraser (smfr) 2015-11-10 17:32:09 PST
https://trac.webkit.org/r192284
Comment 9 mitz 2015-11-10 21:53:47 PST
Comment on attachment 265252 [details]
For EWS

View in context: https://bugs.webkit.org/attachment.cgi?id=265252&action=review

> Source/WebCore/platform/graphics/cocoa/IOSurface.mm:211
> +        NSLog(@"Surface creation failed for options %@", options);

Not LOG_ERROR?

> Source/WebKit2/Shared/mac/RemoteLayerBackingStore.mm:48
> +#if __has_include(<WebKitAdditions/RemoteLayerBackingStoreAdditions.mm>)

We should guard with USE(APPLE_INTERNAL_SDK), not with __has_include, which would just fail silently if the file went missing in the internal SDK.