Bug 151104

Summary: [Streams API] Remove bind usage
Product: WebKit Reporter: Xabier Rodríguez Calvar <calvaris>
Component: New BugsAssignee: Xabier Rodríguez Calvar <calvaris>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, darin, glenn, youennf
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch for landing none

Xabier Rodríguez Calvar
Reported 2015-11-10 09:39:00 PST
[Streams API] Shield bind call
Attachments
Patch (15.80 KB, patch)
2015-11-10 10:00 PST, Xabier Rodríguez Calvar 		no flags
DetailsFormatted DiffDiff
Patch (1.48 KB, patch)
2015-11-11 01:11 PST, Xabier Rodríguez Calvar 		no flags
DetailsFormatted DiffDiff
Patch (10.84 KB, patch)
2015-11-11 01:46 PST, Xabier Rodríguez Calvar 		no flags
DetailsFormatted DiffDiff
Patch (12.38 KB, patch)
2015-11-11 02:29 PST, Xabier Rodríguez Calvar 		no flags
DetailsFormatted DiffDiff
Patch for landing (1.69 KB, patch)
2015-11-11 04:30 PST, Xabier Rodríguez Calvar 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Xabier Rodríguez Calvar
Comment 1 2015-11-10 10:00:52 PST
Created attachment 265193 [details] Patch
youenn fablet
Comment 2 2015-11-10 11:28:03 PST
As I said in bug 151089, I am unsure whether we should support @bind or just an inlined polyfill of it. Also @apply and @call are special cased. Should @bind follow the same path?
Xabier Rodríguez Calvar
Comment 3 2015-11-11 01:11:57 PST
Created attachment 265275 [details] Patch (In reply to comment #2) > As I said in bug 151089, I am unsure whether we should support @bind or just > an inlined polyfill of it. Also @apply and @call are special cased. Should > @bind follow the same path? I might have taken your comment at bug 151089 too literally. I created an inline function to remove the use of bind. About making it a special case as @apply and @call I am not sure if it makes sense now. If we do this, I think we could do a longer review of all things done at the builtins because there are probably similar things.
Xabier Rodríguez Calvar
Comment 4 2015-11-11 01:46:54 PST
Created attachment 265277 [details] Patch Reuploaded the right patch.
Xabier Rodríguez Calvar
Comment 5 2015-11-11 02:29:50 PST
Created attachment 265279 [details] Patch
youenn fablet
Comment 6 2015-11-11 04:00:44 PST
Comment on attachment 265277 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=265277&action=review > LayoutTests/ChangeLog:3 > + [Streams API] Shield bind call Let's rename the bug to something like "Remove bind usage from streams API". Since bind/@bind makes stream code more readable, we may want to create a new bug entry to continue discussing whether we should go with a secure @bind, especially if other built-ins plan to use it. > LayoutTests/streams/streams-security-expected.txt:9 > +PASS Streams and Function: replace bind method in Function prototype We may want to remove that test since bind is not used anymore
Xabier Rodríguez Calvar
Comment 7 2015-11-11 04:30:25 PST
Created attachment 265281 [details] Patch for landing
WebKit Commit Bot
Comment 8 2015-11-11 05:25:30 PST
Comment on attachment 265281 [details] Patch for landing Clearing flags on attachment: 265281 Committed r192309: <http://trac.webkit.org/changeset/192309>
WebKit Commit Bot
Comment 9 2015-11-11 05:25:34 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.