Bug 151080

Summary: sub IC does not properly handle exception handling now that try/catch is compiled in the FTL
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, keith_miller, mark.lam, msaboff
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP
none
patch
ggaren: review+
patch for landing. none

Saam Barati
Reported 2015-11-09 23:52:25 PST
Should be an easy fix.
Attachments
WIP (32.13 KB, patch)
2015-11-10 17:07 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
patch (38.25 KB, patch)
2015-11-10 18:04 PST, Saam Barati 		ggaren: review+
DetailsFormatted DiffDiff
patch for landing. (39.24 KB, patch)
2015-11-13 12:48 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2015-11-10 16:55:00 PST
I'm doing a bit of cleanup as part of this patch too.
Saam Barati
Comment 2 2015-11-10 17:07:19 PST
Created attachment 265250 [details] WIP I think this might be the patch. Need to write some sub tests.
Saam Barati
Comment 3 2015-11-10 18:04:35 PST
Created attachment 265256 [details] patch
WebKit Commit Bot
Comment 4 2015-11-10 18:06:04 PST
Attachment 265256 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/ftl/FTLOSRExit.cpp:49: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] Total errors found: 1 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.
Geoffrey Garen
Comment 5 2015-11-10 19:15:29 PST
Comment on attachment 265256 [details] patch What about Add, and/or other snippets?
Saam Barati
Comment 6 2015-11-11 07:31:12 PST
(In reply to comment #5) > Comment on attachment 265256 [details] > patch > > What about Add, and/or other snippets? They'll need the same treatment once they're introduced in the FTL.
Geoffrey Garen
Comment 7 2015-11-13 10:57:02 PST
Comment on attachment 265256 [details] patch r=me
Saam Barati
Comment 8 2015-11-13 12:48:27 PST
Created attachment 265490 [details] patch for landing.
WebKit Commit Bot
Comment 9 2015-11-13 12:53:59 PST
Attachment 265490 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/ftl/FTLOSRExit.cpp:49: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] Total errors found: 1 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 10 2015-11-13 13:36:20 PST
Comment on attachment 265490 [details] patch for landing. Clearing flags on attachment: 265490 Committed r192439: <http://trac.webkit.org/changeset/192439>
WebKit Commit Bot
Comment 11 2015-11-13 13:36:24 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.