| Summary: | Add WKWebViewConfiguration SPI for a variety of different ex-preferences | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||||
| Component: | New Bugs | Assignee: | Tim Horton <thorton> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | andersca, mitz, sam | ||||||
| Priority: | P2 | ||||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Tim Horton
2015-11-09 17:16:23 PST
Created attachment 265124 [details]
Patch
Created attachment 265127 [details]
Patch
Comment on attachment 265127 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=265127&action=review I thought we put getters before setters. Please change this if that's the case. > Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:-55 > -@property (nonatomic, strong, setter=_setVisitedLinkProvider:) _WKVisitedLinkProvider *_visitedLinkProvider WK_DEPRECATED(10_10, WK_MAC_TBA, 8_0, WK_IOS_TBA, "Please use visitedLinkStore instead"); > - > -@property (nonatomic, strong, setter=_setWebsiteDataStore:) _WKWebsiteDataStore *_websiteDataStore WK_DEPRECATED(10_10, 10_11, 8_0, 9_0, "Please use websiteDataStore instead"); Please move these back so that all deprecated parameters are kept in one place. |