Bug 151070

Summary: Add WKWebViewConfiguration SPI for a variety of different ex-preferences
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, mitz, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch andersca: review+

Tim Horton
Reported 2015-11-09 17:16:23 PST
Add WKWebViewConfiguration SPI for a variety of different ex-preferences
Attachments
Patch (13.43 KB, patch)
2015-11-09 17:16 PST, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (13.43 KB, patch)
2015-11-09 17:25 PST, Tim Horton 		andersca: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2015-11-09 17:16:43 PST
Created attachment 265124 [details] Patch
Tim Horton
Comment 2 2015-11-09 17:25:07 PST
Created attachment 265127 [details] Patch
Anders Carlsson
Comment 3 2015-11-09 17:39:00 PST
Comment on attachment 265127 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=265127&action=review I thought we put getters before setters. Please change this if that's the case. > Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:-55 > -@property (nonatomic, strong, setter=_setVisitedLinkProvider:) _WKVisitedLinkProvider *_visitedLinkProvider WK_DEPRECATED(10_10, WK_MAC_TBA, 8_0, WK_IOS_TBA, "Please use visitedLinkStore instead"); > - > -@property (nonatomic, strong, setter=_setWebsiteDataStore:) _WKWebsiteDataStore *_websiteDataStore WK_DEPRECATED(10_10, 10_11, 8_0, 9_0, "Please use websiteDataStore instead"); Please move these back so that all deprecated parameters are kept in one place.
Tim Horton
Comment 4 2015-11-10 10:06:55 PST
http://trac.webkit.org/changeset/192253
Note You need to log in before you can comment on or make changes to this bug.