Bug 151060

Summary: [EFL] Support an applicationVersion argument to UserAgentEfl::standardUserAgent()
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: WebKit EFLAssignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, lucas.de.marchi
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Gyuyoung Kim 2015-11-09 16:33:45 PST 
*applicationVersion* was missed to support by r192148. This patch adds it as well as missed Darin comments are fixed.
Comment 1 Gyuyoung Kim 2015-11-09 16:37:20 PST 
Created attachment 265116 [details]
Patch
Comment 2 Darin Adler 2015-11-10 10:44:15 PST 
Comment on attachment 265116 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=265116&action=review

> Source/WebCore/platform/efl/UserAgentEfl.cpp:70
> +    String finalApplicationVersion = applicationVersion;

Should do early return if the application name is empty rather than computing an unused string. Probably easier to read than the ?: ternary.
Comment 3 Gyuyoung Kim 2015-11-10 17:40:11 PST 
Comment on attachment 265116 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=265116&action=review

>> Source/WebCore/platform/efl/UserAgentEfl.cpp:70
>> +    String finalApplicationVersion = applicationVersion;
> 
> Should do early return if the application name is empty rather than computing an unused string. Probably easier to read than the ?: ternary.

Yes, right. It is more readable !
Comment 4 Gyuyoung Kim 2015-11-10 18:34:02 PST 
Created attachment 265258 [details]
Patch
Comment 5 WebKit Commit Bot 2015-11-10 19:41:13 PST 
Comment on attachment 265258 [details]
Patch

Clearing flags on attachment: 265258

Committed r192288: <http://trac.webkit.org/changeset/192288>
Comment 6 WebKit Commit Bot 2015-11-10 19:41:16 PST 
All reviewed patches have been landed.  Closing bug.