Bug 151060

Summary: [EFL] Support an applicationVersion argument to UserAgentEfl::standardUserAgent()
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: WebKit EFLAssignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, lucas.de.marchi
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Gyuyoung Kim
Reported 2015-11-09 16:33:45 PST
*applicationVersion* was missed to support by r192148. This patch adds it as well as missed Darin comments are fixed.
Attachments
Patch (2.50 KB, patch)
2015-11-09 16:37 PST, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch (2.65 KB, patch)
2015-11-10 18:34 PST, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2015-11-09 16:37:20 PST
Created attachment 265116 [details] Patch
Darin Adler
Comment 2 2015-11-10 10:44:15 PST
Comment on attachment 265116 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=265116&action=review > Source/WebCore/platform/efl/UserAgentEfl.cpp:70 > + String finalApplicationVersion = applicationVersion; Should do early return if the application name is empty rather than computing an unused string. Probably easier to read than the ?: ternary.
Gyuyoung Kim
Comment 3 2015-11-10 17:40:11 PST
Comment on attachment 265116 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=265116&action=review >> Source/WebCore/platform/efl/UserAgentEfl.cpp:70 >> + String finalApplicationVersion = applicationVersion; > > Should do early return if the application name is empty rather than computing an unused string. Probably easier to read than the ?: ternary. Yes, right. It is more readable !
Gyuyoung Kim
Comment 4 2015-11-10 18:34:02 PST
Created attachment 265258 [details] Patch
WebKit Commit Bot
Comment 5 2015-11-10 19:41:13 PST
Comment on attachment 265258 [details] Patch Clearing flags on attachment: 265258 Committed r192288: <http://trac.webkit.org/changeset/192288>
WebKit Commit Bot
Comment 6 2015-11-10 19:41:16 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.