Bug 151047

Summary: run-jsc-benchmarks doesn't work with internal benchmarks
Product: WebKit Reporter: Geoffrey Garen <ggaren>
Component: New BugsAssignee: Geoffrey Garen <ggaren>
Status: RESOLVED FIXED    
Severity: Normal CC: clopez, fpizlo, ossy
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 151784    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Geoffrey Garen
Reported 2015-11-09 12:32:08 PST
run-jsc-benchmarks doesn't work with internal benchmarks
Attachments
Patch (2.80 KB, patch)
2015-11-09 12:32 PST, Geoffrey Garen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Geoffrey Garen
Comment 1 2015-11-09 12:32:59 PST
Created attachment 265080 [details] Patch
Geoffrey Garen
Comment 2 2015-11-10 14:22:07 PST
Comment on attachment 265080 [details] Patch Clearing flags on attachment: 265080 Committed r192271: <http://trac.webkit.org/changeset/192271>
Geoffrey Garen
Comment 3 2015-11-10 14:22:11 PST
All reviewed patches have been landed. Closing bug.
Carlos Alberto Lopez Perez
Comment 4 2015-11-16 19:21:44 PST
This broke the script for me: FAILED: #<TypeError: no implicit conversion of nil into String> Stack trace: Tools/Scripts/run-jsc-benchmarks:2823:in `initialize' Tools/Scripts/run-jsc-benchmarks:2823:in `new' Tools/Scripts/run-jsc-benchmarks:2823:in `<main>' Use the --help option to get basic usage information.
Csaba Osztrogonác
Comment 5 2015-12-03 03:13:24 PST
(In reply to comment #4) > This broke the script for me: > > FAILED: #<TypeError: no implicit conversion of nil into String> > Stack trace: > Tools/Scripts/run-jsc-benchmarks:2823:in `initialize' > Tools/Scripts/run-jsc-benchmarks:2823:in `new' > Tools/Scripts/run-jsc-benchmarks:2823:in `<main>' > Use the --help option to get basic usage information. already fixed in bug151047
Csaba Osztrogonác
Comment 6 2015-12-03 03:13:46 PST
I meant bug151784.
Note You need to log in before you can comment on or make changes to this bug.