Bug 151043

Summary: B3->Air lowering should support CCall
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, benjamin, commit-queue, ggaren, mark.lam, mhahnenb, msaboff, nrotem, oliver, saam, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 151052, 150279, 151045    
Attachments:
Description Flags
the patch ggaren: review+

Filip Pizlo
Reported 2015-11-09 12:00:06 PST
Patch forthcoming.
Attachments
the patch (17.32 KB, patch)
2015-11-09 14:37 PST, Filip Pizlo 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2015-11-09 14:37:12 PST
Created attachment 265098 [details] the patch
WebKit Commit Bot
Comment 2 2015-11-09 14:40:39 PST
Attachment 265098 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/b3/testb3.cpp:2674: l is incorrectly named. Don't use the single letter 'l' as an identifier name. [readability/naming] [4] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Geoffrey Garen
Comment 3 2015-11-09 15:07:03 PST
Comment on attachment 265098 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=265098&action=review r=me > Source/JavaScriptCore/b3/B3LowerToAir.cpp:1164 > + // Compute the place that this goes onto the stack. On X86_64 and probably other calling ARMv7 and ARM64 too?
Filip Pizlo
Comment 4 2015-11-09 15:51:18 PST
(In reply to comment #3) > Comment on attachment 265098 [details] > the patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=265098&action=review > > r=me > > > Source/JavaScriptCore/b3/B3LowerToAir.cpp:1164 > > + // Compute the place that this goes onto the stack. On X86_64 and probably other calling > > ARMv7 and ARM64 too? Probably, but I haven't checked yet. :-)
Filip Pizlo
Comment 5 2015-11-09 16:27:52 PST
Landed in http://trac.webkit.org/changeset/192187
Note You need to log in before you can comment on or make changes to this bug.