Bug 151033

Summary: [Streams API] Shield promises when prototype is replaced from a promise
Product: WebKit Reporter: Xabier Rodríguez Calvar <calvaris>
Component: New BugsAssignee: Xabier Rodríguez Calvar <calvaris>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, darin, youennf
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Xabier Rodríguez Calvar
Reported 2015-11-09 09:24:26 PST
[Streams API] Shield promises when prototype is replaced from a promise
Attachments
Patch (10.04 KB, patch)
2015-11-09 09:27 PST, Xabier Rodríguez Calvar 		no flags
DetailsFormatted DiffDiff
Patch (9.96 KB, patch)
2015-11-09 11:18 PST, Xabier Rodríguez Calvar 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Xabier Rodríguez Calvar
Comment 1 2015-11-09 09:27:30 PST
Created attachment 265062 [details] Patch
Xabier Rodríguez Calvar
Comment 2 2015-11-09 09:51:29 PST
I'll land this tomorrow as I don't have too much time left.
Xabier Rodríguez Calvar
Comment 3 2015-11-09 11:18:34 PST
Created attachment 265076 [details] Patch Rebased, will cq+ tomorrow
WebKit Commit Bot
Comment 4 2015-11-10 00:51:02 PST
Comment on attachment 265076 [details] Patch Clearing flags on attachment: 265076 Committed r192207: <http://trac.webkit.org/changeset/192207>
WebKit Commit Bot
Comment 5 2015-11-10 00:51:07 PST
All reviewed patches have been landed. Closing bug.
youenn fablet
Comment 6 2015-11-10 05:25:36 PST
Nice work :) The only minor issue I have is that the code is new somehow less readable. It would have been good to be able to keep blabla.....@then. One approach for doing so might be to do specific handling like for @call/@apply. But I prefer your simpler approach. This is not worth it, at least in the current situation where streams API is the only API consuming user-land promises.
Note You need to log in before you can comment on or make changes to this bug.