Bug 151021

Summary: [Streams API] Activate assertions
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebCore Misc.Assignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, calvaris, commit-queue, darin
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Rebasing none

youenn fablet
Reported 2015-11-09 07:22:47 PST
As per the spec, we should enable some @assert in streams implementation.
Attachments
Patch (9.35 KB, patch)
2015-11-09 08:26 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Rebasing (9.37 KB, patch)
2015-11-09 08:34 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2015-11-09 08:26:53 PST
Created attachment 265053 [details] Patch
youenn fablet
Comment 2 2015-11-09 08:34:47 PST
Created attachment 265054 [details] Rebasing
youenn fablet
Comment 3 2015-11-09 08:36:05 PST
Patch activates assertion checking. It fixes a small bug when pull promise is rejected. This actually implements the "if" check of https://streams.spec.whatwg.org/#request-readable-stream-pull (step 7a)
WebKit Commit Bot
Comment 4 2015-11-09 10:06:49 PST
Comment on attachment 265054 [details] Rebasing Clearing flags on attachment: 265054 Committed r192160: <http://trac.webkit.org/changeset/192160>
WebKit Commit Bot
Comment 5 2015-11-09 10:06:54 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.