Bug 151018

Summary: Built-in generator should check that there are no duplicate in JS built-in internal functions
Product: WebKit Reporter: youenn fablet <youennf>
Component: Tools / TestsAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, lforschler
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

youenn fablet
Reported 2015-11-09 06:53:10 PST
Built-in generator should check that there are no duplicate in JS built-in internal functions.
Attachments
Patch (13.39 KB, patch)
2015-11-09 07:11 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2015-11-09 07:11:09 PST
Created attachment 265045 [details] Patch
WebKit Commit Bot
Comment 2 2015-11-09 07:12:49 PST
This patch modifies the JS builtins code generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-builtins-generator-tests --reset-results`)
WebKit Commit Bot
Comment 3 2015-11-09 07:12:59 PST
Attachment 265045 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_combined_header.py:152: [BuiltinsCombinedHeaderGenerator.generate_section_for_code_name_macro] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member [pylint/E1101] [5] Total errors found: 1 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.
youenn fablet
Comment 4 2015-11-09 07:13:38 PST
(In reply to comment #1) > Created attachment 265045 [details] > Patch This patch only checks for duplicate for JSC. Once bug 150482 is landed, WebCore should also be checked (although JSC+WebCore might not be checked).
Blaze Burg
Comment 5 2015-11-09 09:39:50 PST
Comment on attachment 265045 [details] Patch r=me
WebKit Commit Bot
Comment 6 2015-11-09 23:21:22 PST
Comment on attachment 265045 [details] Patch Clearing flags on attachment: 265045 Committed r192202: <http://trac.webkit.org/changeset/192202>
WebKit Commit Bot
Comment 7 2015-11-09 23:21:25 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.