Bug 151013

Summary:

Fresh checkout fails to build on windows, DumpRenderTree can't find cairo_win.h

Product:

WebKit

Reporter:

isaac+webkit

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, bfulgham, commit-queue, lforschler, ossy, peavo

Priority:

Version:

WebKit Nightly Build

Hardware:

OS:

Windows 10

Attachments:

Description	Flags
Patch	none

isaac+webkit

Reported 2015-11-08 20:43:03 PST

On Windows 10 64-bit machine with Visual Studio 2015 Community Edition: Followed instructions on http://trac.webkit.org/wiki/WindowsWithoutCygwin (except without iTunes or DirectX); except for building. Then in a "normal" command prompt ("start->run cmd.exe") cd PATH_TO_WEBKIT perl Tools\Scripts\build-webkit --wincairo --release Causes build failures in DumpRenderTree: C:\work\WebKit\Tools\DumpRenderTree\cairo\PixelDumpSupportCairo.h(38): fatal error C1083: Cannot open include file: 'cairo-win32.h': No such file or directory (compiling source file C:\work\WebKit\Tools\DumpRenderTree\PixelDumpSupport.cpp) [C:\work\WebKit\WebKitBuild\Release\Tools\DumpRenderTree\DumpRenderTreeLib.vcxproj] C:\work\WebKit\Tools\DumpRenderTree\cairo\PixelDumpSupportCairo.h(38): fatal error C1083: Cannot open include file: 'cairo-win32.h': No such file or directory (compiling source file C:\work\WebKit\Tools\DumpRenderTree\win\PixelDumpSupportWin.cpp) [C:\work\WebKit\WebKitBuild\Release\Tools\DumpRenderTree\DumpRenderTreeLib.vcxproj] c:\work\webkit\tools\dumprendertree\cairo\PixelDumpSupportCairo.h(38): fatal error C1083: Cannot open include file: 'cairo-win32.h': No such file or directory (compiling source file C:\work\WebKit\Tools\DumpRenderTree\cairo\PixelDumpSupportCairo.cpp) [C:\work\WebKit\WebKitBuild\Release\Tools\DumpRenderTree\DumpRenderTreeLib.vcxproj] C:\work\WebKit\Tools\DumpRenderTree\win\ImageDiffCairo.cpp(32): fatal error C1083: Cannot open include file: 'cairo.h': No such file or directory [C:\work\WebKit\WebKitBuild\Release\Tools\DumpRenderTree\ImageDiffLib.vcxproj] Looking into DumpRenderTreeLib.vcxproj it doesn't have the fully qualified path to the WebkitLibraries\win\include\cairo directory, it just has "\include\cairo".

Attachments
Patch (1.53 KB, patch) 2015-11-08 22:14 PST, isaac+webkit	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

isaac+webkit

Comment 1 2015-11-08 22:14:20 PST

Created attachment 265032 [details] Patch

Brent Fulgham

Comment 2 2015-11-09 09:50:21 PST

I think this looks good, but let's let Alex Christensen double-check before we land.

Alex Christensen

Comment 3 2015-11-09 10:27:29 PST

Comment on attachment 265032 [details] Patch Yep.

WebKit Commit Bot

Comment 4 2015-11-09 11:17:54 PST

Comment on attachment 265032 [details] Patch Clearing flags on attachment: 265032 Committed r192167: <http://trac.webkit.org/changeset/192167>

WebKit Commit Bot

Comment 5 2015-11-09 11:17:58 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.