| Summary: | Some style changes cause tatechuyoko to be drawn off center | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Myles C. Maxfield <mmaxfield> | ||||
| Component: | New Bugs | Assignee: | Myles C. Maxfield <mmaxfield> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, dino, esprehn+autocc, glenn, hyatt, jonlee, kondapallykalyan, simon.fraser, thorton, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | 151186 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
|
Description
Myles C. Maxfield
2015-11-06 17:08:29 PST
Created attachment 264983 [details]
Patch
Comment on attachment 264983 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=264983&action=review > Source/WebCore/rendering/RenderCombineText.cpp:93 > + // An ancestor element may trigger us to relayout even when we're already combined. We should use better grammar in this comment. I don’t think “trigger us to relayout” is grammatical. > Source/WebCore/rendering/RenderCombineText.cpp:149 > + RenderText::setRenderedText(objectReplacementCharacterString.get().impl()); The .impl() here is really mysterious. Why would we need to include that? The function takes a const String&, not a StringImpl*. I think that saying impl() just introduces another String temporary and thus reference count churn. Committed r192169: <http://trac.webkit.org/changeset/192169> |