Bug 15096

Summary: CG and non-CG GIF decoders have different frame duration minima
Product: WebKit Reporter: Peter Kasting <pkasting>
Component: ImagesAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 523.x (Safari 3)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
patch v1 mjs: review+

Peter Kasting
Reported 2007-08-27 17:17:41 PDT
ImageSourceCG.cpp uses a WinIE-like >50 ms minimum cutoff for GIF frame durations. But the code in image-decoders/gif/GIFImageReader.cpp (used by Cairo, QT) uses =10 ms. Patch to make the non-CG ImageSources work like ImageSourceCG coming shortly.
Attachments
patch v1 (3.66 KB, patch)
2007-08-27 17:21 PDT, Peter Kasting 		mjs: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Peter Kasting
Comment 1 2007-08-27 17:21:09 PDT
Created attachment 16137 [details] patch v1 This makes the various ImageSource*.cpp files look closer to ImageSourceCG.cpp, including using the same threshold value. It also makes GIFImageReader.cpp closer to the original Mozilla source.
Maciej Stachowiak
Comment 2 2007-08-28 21:19:39 PDT
Comment on attachment 16137 [details] patch v1 r=me
Mark Rowe (bdash)
Comment 3 2007-08-29 10:40:12 PDT
Landed in r25295.
Note You need to log in before you can comment on or make changes to this bug.