Bug 15096 - CG and non-CG GIF decoders have different frame duration minima
Summary: CG and non-CG GIF decoders have different frame duration minima
Alias: None
Product: WebKit
Classification: Unclassified
Component: Images (show other bugs)
Version: 523.x (Safari 3)
Hardware: PC All
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2007-08-27 17:17 PDT by Peter Kasting
Modified: 2007-08-29 10:40 PDT (History)
0 users

See Also:

patch v1 (3.66 KB, patch)
2007-08-27 17:21 PDT, Peter Kasting
mjs: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Kasting 2007-08-27 17:17:41 PDT
ImageSourceCG.cpp uses a WinIE-like >50 ms minimum cutoff for GIF frame durations.  But the code in image-decoders/gif/GIFImageReader.cpp (used by Cairo, QT) uses =10 ms.

Patch to make the non-CG ImageSources work like ImageSourceCG coming shortly.
Comment 1 Peter Kasting 2007-08-27 17:21:09 PDT
Created attachment 16137 [details]
patch v1

This makes the various ImageSource*.cpp files look closer to ImageSourceCG.cpp, including using the same threshold value.  It also makes GIFImageReader.cpp closer to the original Mozilla source.
Comment 2 Maciej Stachowiak 2007-08-28 21:19:39 PDT
Comment on attachment 16137 [details]
patch v1

Comment 3 Mark Rowe (bdash) 2007-08-29 10:40:12 PDT
Landed in r25295.