Bug 150938

Summary: Web Inspector: Toolbar "Inspect Node" button not highlighting when active
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, simon.fraser, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2015-11-05 10:55:52 PST
* SUMMARY Toolbar "Inspect Node" button not highlighting when active. * STEPS TO REPRODUCE 1. Inspect this page 2. Click "Inspect Node" button in Toolbar => expected button to appear active, it did not
Attachments
[PATCH] Proposed Fix (1.58 KB, patch)
2015-11-05 10:57 PST, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2015-11-05 10:56:18 PST
<rdar://problem/23414255>
Joseph Pecoraro
Comment 2 2015-11-05 10:57:26 PST
Created attachment 264871 [details] [PATCH] Proposed Fix
Simon Fraser (smfr)
Comment 3 2015-11-05 11:17:44 PST
Could this breakage have been detected by regression testing?
WebKit Commit Bot
Comment 4 2015-11-05 11:28:31 PST
Comment on attachment 264871 [details] [PATCH] Proposed Fix Clearing flags on attachment: 264871 Committed r192063: <http://trac.webkit.org/changeset/192063>
WebKit Commit Bot
Comment 5 2015-11-05 11:28:35 PST
All reviewed patches have been landed. Closing bug.
Blaze Burg
Comment 6 2015-11-05 11:29:42 PST
(In reply to comment #3) > Could this breakage have been detected by regression testing? Currently, we do not have any test coverage for purely UI regressions like this one. It would be nice, but we'd need to have better user automation support to simulate clicking the element. And then we'd need to look at the computed style or something. Preventing these regressions is high on my list of ways to reduce Web Inspector patch churn.
Note You need to log in before you can comment on or make changes to this bug.