Bug 150918

Summary: Web Inspector: Load markers persist in timeline ruler after resetting recording
Product: WebKit Reporter: Matt Baker <mattbaker>
Component: Web InspectorAssignee: Matt Baker <mattbaker>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[Patch] Proposed Fix none

Description Matt Baker 2015-11-04 19:02:32 PST 
* SUMMARY
Load markers persist in timeline ruler after resetting recording. This doesn't apply to the current time marker, which is correctly reset to time zero.

* STEPS TO REPRODUCE
1. Inspector -> Timelines
2. Record a page reload
3. Stop the recording once the blue and red load markers appear (or let it stop on its own)
4. Reset the recording (Click the trashcan icon)
  => Current time marker resets to zero, but load markers remain
Comment 1 Radar WebKit Bug Importer 2015-11-04 19:03:01 PST 
<rdar://problem/23406324>
Comment 2 Matt Baker 2015-11-04 19:06:06 PST 
Created attachment 264834 [details]
[Patch] Proposed Fix
Comment 3 Joseph Pecoraro 2015-11-04 19:19:05 PST 
Comment on attachment 264834 [details]
[Patch] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=264834&action=review

r=me

> Source/WebInspectorUI/ChangeLog:11
> +        (WebInspector.OverviewTimelineView.prototype._recordingReset):
> +        Clears ruler markers on recording reset. Adds current time marker back.

Good find! When is the recording reset? Only the clear button and initial load? Is there any other way?
Comment 4 WebKit Commit Bot 2015-11-04 20:10:19 PST 
Comment on attachment 264834 [details]
[Patch] Proposed Fix

Clearing flags on attachment: 264834

Committed r192050: <http://trac.webkit.org/changeset/192050>
Comment 5 WebKit Commit Bot 2015-11-04 20:10:23 PST 
All reviewed patches have been landed.  Closing bug.