Summary: | Implement compareDouble in B3/Air | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||||||
Component: | JavaScriptCore | Assignee: | Filip Pizlo <fpizlo> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | barraclough, benjamin, ggaren, keith_miller, mark.lam, mhahnenb, msaboff, nrotem, oliver, saam, sam | ||||||||
Priority: | P2 | ||||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Bug Depends on: | 150721, 151009, 152420 | ||||||||||
Bug Blocks: | 150279, 150991 | ||||||||||
Attachments: |
|
Description
Filip Pizlo
2015-11-04 14:25:26 PST
I'm implementing this as part of https://bugs.webkit.org/show_bug.cgi?id=152358. *** This bug has been marked as a duplicate of bug 152358 *** ... Created attachment 267674 [details]
the patch
Created attachment 267701 [details]
the patch
Created attachment 267702 [details]
the patch
Comment on attachment 267702 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=267702&action=review > Source/JavaScriptCore/b3/testb3.cpp:9519 > + RUN(testEqualDouble(PNaN, PNaN, false)); Can you please add (0, -0.)? (In reply to comment #6) > Comment on attachment 267702 [details] > the patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=267702&action=review > > > Source/JavaScriptCore/b3/testb3.cpp:9519 > > + RUN(testEqualDouble(PNaN, PNaN, false)); > > Can you please add (0, -0.)? Good idea! Landed in http://trac.webkit.org/changeset/194320 |