Bug 150903

Summary: Implement compareDouble in B3/Air
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, benjamin, ggaren, keith_miller, mark.lam, mhahnenb, msaboff, nrotem, oliver, saam, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 150721, 151009, 152420    
Bug Blocks: 150279, 150991    
Attachments:
Description Flags
the patch
none
the patch
none
the patch benjamin: review+

Filip Pizlo
Reported 2015-11-04 14:25:26 PST
We need it. It's OK if the MacroAssembler implements this with branches.
Attachments
the patch (7.84 KB, patch)
2015-12-18 18:35 PST, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (7.83 KB, patch)
2015-12-19 12:45 PST, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (7.79 KB, patch)
2015-12-19 12:47 PST, Filip Pizlo 		benjamin: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2015-12-16 16:18:46 PST
I'm implementing this as part of https://bugs.webkit.org/show_bug.cgi?id=152358. *** This bug has been marked as a duplicate of bug 152358 ***
Filip Pizlo
Comment 2 2015-12-18 10:50:40 PST
...
Filip Pizlo
Comment 3 2015-12-18 18:35:48 PST
Created attachment 267674 [details] the patch
Filip Pizlo
Comment 4 2015-12-19 12:45:10 PST
Created attachment 267701 [details] the patch
Filip Pizlo
Comment 5 2015-12-19 12:47:32 PST
Created attachment 267702 [details] the patch
Benjamin Poulain
Comment 6 2015-12-20 06:41:55 PST
Comment on attachment 267702 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=267702&action=review > Source/JavaScriptCore/b3/testb3.cpp:9519 > + RUN(testEqualDouble(PNaN, PNaN, false)); Can you please add (0, -0.)?
Filip Pizlo
Comment 7 2015-12-20 07:53:01 PST
(In reply to comment #6) > Comment on attachment 267702 [details] > the patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=267702&action=review > > > Source/JavaScriptCore/b3/testb3.cpp:9519 > > + RUN(testEqualDouble(PNaN, PNaN, false)); > > Can you please add (0, -0.)? Good idea!
Filip Pizlo
Comment 8 2015-12-20 11:54:29 PST
Landed in http://trac.webkit.org/changeset/194320
Note You need to log in before you can comment on or make changes to this bug.