Bug 150901

Summary: Fix crashing and flaky UIScriptController-based tests in fast/events/ios
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: Tools / TestsAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, lforschler, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Wenson Hsieh 2015-11-04 13:31:53 PST
Fix crashing and flaky tests in LayoutTests/fast/events/ios. One of the main causes of our crashes is that zooming and keyboard callbacks that have been set by previous tests are not cleared before running the next test, so code from the previous test may be executed during the next test if the test does not set the callback to something else. This causes us to access the previous deallocated UIScriptController and crash.
Comment 1 Wenson Hsieh 2015-11-04 13:39:44 PST
<rdar://problem/23261499>
Comment 2 Wenson Hsieh 2015-11-04 13:57:22 PST
Created attachment 264810 [details]
Patch
Comment 3 WebKit Commit Bot 2015-11-04 15:35:41 PST
Comment on attachment 264810 [details]
Patch

Clearing flags on attachment: 264810

Committed r192039: <http://trac.webkit.org/changeset/192039>
Comment 4 WebKit Commit Bot 2015-11-04 15:35:44 PST
All reviewed patches have been landed.  Closing bug.