Bug 150866

Summary: Rename DFG's compileAdd to compileArithAdd.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
the patch. none

Mark Lam
Reported 2015-11-03 16:06:02 PST
The function is supposed to only generate code to do arithmetic on numeric types. Naming it compileArithAdd() is more accurate, and is consistent with the name of the node it emits code for (i.e. ArithAdd) as well as other compiler functions for analogous operations e.g. compileArithSub.
Attachments
the patch. (3.24 KB, patch)
2015-11-03 16:09 PST, Mark Lam 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2015-11-03 16:09:30 PST
Created attachment 264748 [details] the patch.
WebKit Commit Bot
Comment 2 2015-11-03 17:01:32 PST
Comment on attachment 264748 [details] the patch. Clearing flags on attachment: 264748 Committed r192000: <http://trac.webkit.org/changeset/192000>
WebKit Commit Bot
Comment 3 2015-11-03 17:01:35 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.