Bug 150853

Summary: Accept 8 and 4 value hex colors (#RRGGBBAA)
Product: WebKit Reporter: Dean Jackson <dino>
Component: New BugsAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: 7raivis, buildbot, jonlee, rniwa, tabatkins, webkit-bug-importer, webkit
Priority: P2 Keywords: InRadar, WebExposed
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews102 for mac-mavericks
none
Archive of layout-test-results from ews104 for mac-mavericks-wk2
none
Archive of layout-test-results from ews112 for mac-yosemite
none
Patch simon.fraser: review+

Description Dean Jackson 2015-11-03 13:28:15 PST
Accept 8 and 4 value hex colors (#RRGGBBAA)
Comment 1 Radar WebKit Bug Importer 2015-11-03 13:29:18 PST
<rdar://problem/23380930>
Comment 2 Dean Jackson 2015-11-03 13:52:38 PST
Created attachment 264720 [details]
Patch
Comment 3 Build Bot 2015-11-03 14:36:20 PST
Comment on attachment 264720 [details]
Patch

Attachment 264720 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/378494

New failing tests:
imported/w3c/canvas/2d.fillStyle.parse.invalid.hex8.html
imported/w3c/canvas/2d.fillStyle.parse.invalid.hex4.html
fast/dom/attribute-legacy-colors.html
svg/dom/rgb-color-parser.html
canvas/philip/tests/2d.fillStyle.parse.invalid.hex4.html
imported/w3c/css/css-color-3/t421-rgb-hex-parsing-f.xht
canvas/philip/tests/2d.fillStyle.parse.invalid.hex8.html
Comment 4 Build Bot 2015-11-03 14:36:22 PST
Created attachment 264727 [details]
Archive of layout-test-results from ews102 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-mavericks  Platform: Mac OS X 10.9.5
Comment 5 Build Bot 2015-11-03 14:39:55 PST
Comment on attachment 264720 [details]
Patch

Attachment 264720 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/378495

New failing tests:
imported/w3c/canvas/2d.fillStyle.parse.invalid.hex8.html
imported/w3c/canvas/2d.fillStyle.parse.invalid.hex4.html
fast/dom/attribute-legacy-colors.html
svg/dom/rgb-color-parser.html
canvas/philip/tests/2d.fillStyle.parse.invalid.hex4.html
imported/w3c/css/css-color-3/t421-rgb-hex-parsing-f.xht
canvas/philip/tests/2d.fillStyle.parse.invalid.hex8.html
Comment 6 Build Bot 2015-11-03 14:39:58 PST
Created attachment 264729 [details]
Archive of layout-test-results from ews104 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5
Comment 7 Build Bot 2015-11-03 14:49:02 PST
Comment on attachment 264720 [details]
Patch

Attachment 264720 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/378520

New failing tests:
imported/w3c/canvas/2d.fillStyle.parse.invalid.hex8.html
imported/w3c/canvas/2d.fillStyle.parse.invalid.hex4.html
fast/dom/attribute-legacy-colors.html
svg/dom/rgb-color-parser.html
canvas/philip/tests/2d.fillStyle.parse.invalid.hex4.html
imported/w3c/css/css-color-3/t421-rgb-hex-parsing-f.xht
canvas/philip/tests/2d.fillStyle.parse.invalid.hex8.html
Comment 8 Build Bot 2015-11-03 14:49:05 PST
Created attachment 264732 [details]
Archive of layout-test-results from ews112 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 9 Dean Jackson 2015-11-03 16:22:31 PST
Created attachment 264751 [details]
Patch
Comment 10 Dean Jackson 2015-11-04 09:51:01 PST
Committed r192023: <http://trac.webkit.org/changeset/192023>
Comment 11 Zoƫ Bijl 2016-05-26 17:55:55 PDT
Thanks for fixing this!
Comment 12 Dean Jackson 2016-08-03 13:23:42 PDT
*** Bug 39140 has been marked as a duplicate of this bug. ***