Bug 150851

Summary: [MediaStream] A RealtimeMediaSource should begin producing data automatically
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: adam.bergkvist, commit-queue, jer.noble, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch.
none
Patch for landing. none

Eric Carlson
Reported 2015-11-03 13:12:48 PST
A realtime media source should begin producing data when it is added to a stream. Remove RealtimeMediaSource::setEnabled and RealtimeMediaSource::enabled and associated callbacks because a source does not have an "enabled" state, only "muted".
Attachments
Proposed patch. (13.28 KB, patch)
2015-11-03 13:30 PST, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Patch for landing. (13.24 KB, patch)
2015-11-04 09:36 PST, Eric Carlson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-11-03 13:14:02 PST
<rdar://problem/23380636>
Eric Carlson
Comment 2 2015-11-03 13:30:29 PST
Created attachment 264718 [details] Proposed patch.
Adam Bergkvist
Comment 3 2015-11-04 04:13:54 PST
Looks good to me
Jer Noble
Comment 4 2015-11-04 09:22:16 PST
Comment on attachment 264718 [details] Proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=264718&action=review > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:456 > > + characteristicsChanged(); > m_readyState = readyState; > Do you maybe want to throw the characteristicsChanged() notification _after_ updating the ready state? Because if anyone checks ready state from within that call, they'll see it as unchanged.
Eric Carlson
Comment 5 2015-11-04 09:36:13 PST
Created attachment 264793 [details] Patch for landing.
WebKit Commit Bot
Comment 6 2015-11-04 10:56:01 PST
Comment on attachment 264793 [details] Patch for landing. Clearing flags on attachment: 264793 Committed r192028: <http://trac.webkit.org/changeset/192028>
Note You need to log in before you can comment on or make changes to this bug.