Bug 150831

Summary: B3::Stackmap should be a superclass of B3::PatchpointValue and B3::CheckValue rather than being one of their members
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, benjamin, commit-queue, ggaren, mark.lam, mhahnenb, msaboff, nrotem, oliver, saam, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 150279    
Attachments:
Description Flags
it's a start
none
more
none
the patch benjamin: review+

Description Filip Pizlo 2015-11-02 20:35:34 PST 
This will simplify things a lot.
Comment 1 Filip Pizlo 2015-11-02 20:36:37 PST 
Created attachment 264659 [details]
it's a start
Comment 2 Filip Pizlo 2015-11-03 11:06:38 PST 
Created attachment 264700 [details]
more

Of course it doesn't compile yet.
Comment 3 Filip Pizlo 2015-11-03 11:33:22 PST 
Created attachment 264703 [details]
the patch
Comment 4 WebKit Commit Bot 2015-11-03 11:36:16 PST 
Attachment 264703 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/b3/B3MemoryValue.h:68:  The parameter name "comma" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/b3/testb3.cpp:1214:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 2 in 39 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Benjamin Poulain 2015-11-03 15:20:52 PST 
Comment on attachment 264703 [details]
the patch

rs=me
Comment 6 Filip Pizlo 2015-11-03 16:14:39 PST 
Landed in http://trac.webkit.org/changeset/191993