Bug 150829

Summary: Clean up NETWORK_SESSION code after r191848
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 150834    
Attachments:
Description Flags
Patch none

Alex Christensen
Reported 2015-11-02 17:50:48 PST
Clean up NETWORK_SESSION code after r191848
Attachments
Patch (3.50 KB, patch)
2015-11-02 17:51 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2015-11-02 17:51:03 PST
Created attachment 264652 [details] Patch
Alex Christensen
Comment 2 2015-11-02 17:51:45 PST
Fixed Darin's comment in https://bugs.webkit.org/show_bug.cgi?id=150742
Darin Adler
Comment 3 2015-11-02 22:08:09 PST
Comment on attachment 264652 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=264652&action=review > Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp:474 > - sharedDidReceiveBuffer(WTF::move(buffer), buffer->size()); > + auto size = buffer->size(); > + sharedDidReceiveBuffer(WTF::move(buffer), size); This is not clean up; it’s fixing a potentially serious bug.
WebKit Commit Bot
Comment 4 2015-11-03 01:17:45 PST
Comment on attachment 264652 [details] Patch Clearing flags on attachment: 264652 Committed r191942: <http://trac.webkit.org/changeset/191942>
WebKit Commit Bot
Comment 5 2015-11-03 01:17:48 PST
All reviewed patches have been landed. Closing bug.
Alex Christensen
Comment 6 2015-11-03 12:39:46 PST
(In reply to comment #3) > Comment on attachment 264652 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=264652&action=review > > > Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp:474 > > - sharedDidReceiveBuffer(WTF::move(buffer), buffer->size()); > > + auto size = buffer->size(); > > + sharedDidReceiveBuffer(WTF::move(buffer), size); > > This is not clean up; it’s fixing a potentially serious bug. I agree. I think this should've caused crashes, but it didn't. I also think we should remove the size parameter because it's not really used.
Note You need to log in before you can comment on or make changes to this bug.