Bug 150795

Summary: Fix the FTL JIT build with system LLVM on Linux
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: JavaScriptCoreAssignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, commit-queue, fpizlo, mcatanzaro, ossy, ysuzuki
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 143605    
Attachments:
Description Flags
Patch
none
Patch for landing none

Description Csaba Osztrogonác 2015-11-02 05:38:27 PST
Now it builds fine with LLVM jhbuild modules, but not with system LLVM. Let's fix it.
Comment 1 Csaba Osztrogonác 2015-11-02 05:40:33 PST
--system-libs option was introduced in LLVM 3.6, let's use it to add system
libraries instead of hard coding them to CMakeLists.txt

Additionally we will need libedit-dev package to be able link libedit.a .
Comment 2 Csaba Osztrogonác 2015-11-02 05:42:58 PST
Created attachment 264577 [details]
Patch
Comment 3 Michael Catanzaro 2015-11-02 07:12:12 PST
Please also add the Arch package libedit and the Fedora package libedit-devel.

In the future, you can search out these names at:

https://www.archlinux.org/packages/
https://admin.fedoraproject.org/pkgdb/
Comment 4 Csaba Osztrogonác 2015-11-02 07:35:45 PST
(In reply to comment #3)
> Please also add the Arch package libedit and the Fedora package
> libedit-devel.
> 
> In the future, you can search out these names at:
> 
> https://www.archlinux.org/packages/
> https://admin.fedoraproject.org/pkgdb/

Oops, sorry. I'll add them before landing.
Comment 5 Csaba Osztrogonác 2015-11-02 07:36:05 PST
Created attachment 264587 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2015-11-02 08:25:32 PST
Comment on attachment 264587 [details]
Patch for landing

Clearing flags on attachment: 264587

Committed r191889: <http://trac.webkit.org/changeset/191889>
Comment 7 WebKit Commit Bot 2015-11-02 08:25:35 PST
All reviewed patches have been landed.  Closing bug.