Bug 150793

Summary: Clean up ENABLE(ES6_ARROWFUNCTION_SYNTAX) ifdefs and keep minimal set of them
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Blocker CC: commit-queue, ggaren, ysuzuki
Priority: P1    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 150769    
Attachments:
Description Flags
Patch none

Csaba Osztrogonác
Reported 2015-11-02 03:13:01 PST
https://trac.webkit.org/changeset/191875 broke the !ENABLE(ES6_ARROWFUNCTION_SYNTAX) build: ../../Source/JavaScriptCore/parser/Parser.cpp: In member function 'bool JSC::Parser<T>::parseFunctionInfo(TreeBuilder&, JSC::FunctionRequirements, JSC::SourceParseMode, bool, JSC::ConstructorKind, JSC::SuperBinding, int, JSC::ParserFunctionInfo<TreeBuilder>&, JSC::Parser<T>::FunctionDefinitionType)': ../../Source/JavaScriptCore/parser/Parser.cpp:1695:25: error: 'ARROWFUNCTION' was not declared in this scope ( I don't have any time to investigate this regression, feel free to pick it up. )
Attachments
Patch (3.87 KB, patch)
2015-11-02 08:00 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2015-11-02 07:08:18 PST
I'll check this.
Yusuke Suzuki
Comment 2 2015-11-02 07:19:59 PST
Thanks! This is my fault. I accidentally used ARROWFUNCTION token without ifdef. I'll create the patch once I returned home (in one hour).
Yusuke Suzuki
Comment 3 2015-11-02 07:54:05 PST
I'll keep the minimal ENABLE(ES6_ARROWFUNCTION_SYNTAX) and clean up many ifdefs!
Yusuke Suzuki
Comment 4 2015-11-02 08:00:21 PST
Created attachment 264588 [details] Patch
Yusuke Suzuki
Comment 5 2015-11-02 08:08:23 PST
One difference from the original one is, this patch enables lexing `=>` token. But the parser does not use it for any reductions. This token is just rejected.
Yusuke Suzuki
Comment 6 2015-11-03 01:49:17 PST
Comment on attachment 264588 [details] Patch Thanks!
WebKit Commit Bot
Comment 7 2015-11-03 02:37:13 PST
Comment on attachment 264588 [details] Patch Clearing flags on attachment: 264588 Committed r191946: <http://trac.webkit.org/changeset/191946>
WebKit Commit Bot
Comment 8 2015-11-03 02:37:16 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.