Bug 150732

Summary: Use convenience function in sandbox profile
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit2Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, bfulgham, commit-queue, ddkilzer, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: iPhone / iPad   
OS: All   
Attachments:
Description Flags
Patch none

Brent Fulgham
Reported 2015-10-30 13:27:41 PDT
This bug cleans up one of the sandbox profiles by using a convenience function to define the proper logging setup, rather than manually specifying each piece of the log directory permissions required.
Attachments
Patch (1.42 KB, patch)
2015-10-30 13:36 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2015-10-30 13:36:30 PDT
Created attachment 264412 [details] Patch
Brent Fulgham
Comment 2 2015-10-30 13:37:14 PDT
<rdar://problem/23287894>
Geoffrey Garen
Comment 3 2015-10-30 13:42:20 PDT
Comment on attachment 264412 [details] Patch Is awd-log-directory available on older OS's?
Brent Fulgham
Comment 4 2015-10-30 15:30:44 PDT
(In reply to comment #3) > Comment on attachment 264412 [details] > Patch > > Is awd-log-directory available on older OS's? This profile is only used on iOS. The function was added in iOS 9, so it's really only usable on current builds. But I'm not sure if we support building WebKit on older iOS revisions.
Alexey Proskuryakov
Comment 5 2015-10-30 20:35:14 PDT
Comment on attachment 264412 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=264412&action=review > Source/WebKit2/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:-84 > -(allow mach-lookup (global-name "com.apple.awdd")) Is this unnecessary?
Brent Fulgham
Comment 6 2015-11-01 15:51:26 PST
Comment on attachment 264412 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=264412&action=review >> Source/WebKit2/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:-84 >> -(allow mach-lookup (global-name "com.apple.awdd")) > > Is this unnecessary? It's done as part of the (awd-log-directory ...) function.
WebKit Commit Bot
Comment 7 2015-11-01 17:02:19 PST
Comment on attachment 264412 [details] Patch Clearing flags on attachment: 264412 Committed r191872: <http://trac.webkit.org/changeset/191872>
WebKit Commit Bot
Comment 8 2015-11-01 17:02:22 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.