Bug 150718

Summary: Modern IDB: Support IDBObjectStore.get() for IDBKeyRanges
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebCore Misc.Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, alecflett, commit-queue, jsbell
Priority: P2    
Version: Safari 9   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 149117    
Attachments:
Description Flags
Patch v1
beidson: review-
patch v2 achristensen: review+

Description Brady Eidson 2015-10-30 08:55:55 PDT 
Modern IDB: Support IDBObjectStore.get() for IDBKeyRanges
Comment 1 Brady Eidson 2015-10-30 10:08:54 PDT 
Created attachment 264399 [details]
Patch v1
Comment 2 Brady Eidson 2015-10-30 10:09:29 PDT 
Comment on attachment 264399 [details]
Patch v1

Forgot to add the results for the test
Comment 3 Brady Eidson 2015-10-30 10:36:20 PDT 
Created attachment 264401 [details]
patch v2
Comment 4 Alex Christensen 2015-10-30 10:53:17 PDT 
Comment on attachment 264401 [details]
patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=264401&action=review

> LayoutTests/storage/indexeddb/modern/get-keyrange.html:74
> +    

Add some tests with null, strings, arrays, NaN, {}, etc.

> Source/WebCore/Modules/indexeddb/IDBKeyRangeData.cpp:39
> +    , lowerOpen(false)

lowerOpen { false } in header instead of three other copies.
Comment 5 Brady Eidson 2015-10-30 17:19:15 PDT 
https://trac.webkit.org/changeset/191832