Bug 150705

Summary: [EFL] Add try_close API to handle beforeunload event
Product: WebKit Reporter: Ryuan Choi <ryuan.choi>
Component: WebKit EFLAssignee: Ryuan Choi <ryuan.choi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, gyuyoung.kim, lucas.de.marchi
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Ryuan Choi
Reported 2015-10-29 19:51:41 PDT
In order to show beforeunload confirm panel when closing web page which contains beforeunload event, we should call tryClose.
Attachments
Patch (6.31 KB, patch)
2015-10-29 20:01 PDT, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
Patch (6.22 KB, patch)
2015-11-03 23:40 PST, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryuan Choi
Comment 1 2015-10-29 20:01:36 PDT
Created attachment 264375 [details] Patch
Gyuyoung Kim
Comment 2 2015-11-03 22:11:24 PST
Comment on attachment 264375 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=264375&action=review LGTM except for trivial nits. > Source/WebKit2/ChangeLog:9 > + except on termination. s/except on/instead of/g ? > Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:129 > +void ewk_view_try_close(Evas_Object* ewkView) Add *const* keyword.
Ryuan Choi
Comment 3 2015-11-03 23:40:47 PST
Created attachment 264776 [details] Patch
Ryuan Choi
Comment 4 2015-11-03 23:42:52 PST
(In reply to comment #2) > Comment on attachment 264375 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=264375&action=review > > LGTM except for trivial nits. > > > Source/WebKit2/ChangeLog:9 > > + except on termination. > > s/except on/instead of/g ? > I removed this confusing sentence. > > Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:129 > > +void ewk_view_try_close(Evas_Object* ewkView) > > Add *const* keyword. I am not sure, this api has a behavior which calls popup or close callback.
WebKit Commit Bot
Comment 5 2015-11-05 01:30:34 PST
Comment on attachment 264776 [details] Patch Clearing flags on attachment: 264776 Committed r192053: <http://trac.webkit.org/changeset/192053>
WebKit Commit Bot
Comment 6 2015-11-05 01:30:38 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.