Bug 150705

Summary: [EFL] Add try_close API to handle beforeunload event
Product: WebKit Reporter: Ryuan Choi <ryuan.choi>
Component: WebKit EFLAssignee: Ryuan Choi <ryuan.choi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, gyuyoung.kim, lucas.de.marchi
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Ryuan Choi 2015-10-29 19:51:41 PDT 
In order to show beforeunload confirm panel when closing web page which contains beforeunload event,
we should call tryClose.
Comment 1 Ryuan Choi 2015-10-29 20:01:36 PDT 
Created attachment 264375 [details]
Patch
Comment 2 Gyuyoung Kim 2015-11-03 22:11:24 PST 
Comment on attachment 264375 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=264375&action=review

LGTM except for trivial nits.

> Source/WebKit2/ChangeLog:9
> +        except on termination.

s/except on/instead of/g ?

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:129
> +void ewk_view_try_close(Evas_Object* ewkView)

Add *const* keyword.
Comment 3 Ryuan Choi 2015-11-03 23:40:47 PST 
Created attachment 264776 [details]
Patch
Comment 4 Ryuan Choi 2015-11-03 23:42:52 PST 
(In reply to comment #2)
> Comment on attachment 264375 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=264375&action=review
> 
> LGTM except for trivial nits.
> 
> > Source/WebKit2/ChangeLog:9
> > +        except on termination.
> 
> s/except on/instead of/g ?
> 
I removed this confusing sentence.

> > Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:129
> > +void ewk_view_try_close(Evas_Object* ewkView)
> 
> Add *const* keyword.

I am not sure, this api has a behavior which calls popup or close callback.
Comment 5 WebKit Commit Bot 2015-11-05 01:30:34 PST 
Comment on attachment 264776 [details]
Patch

Clearing flags on attachment: 264776

Committed r192053: <http://trac.webkit.org/changeset/192053>
Comment 6 WebKit Commit Bot 2015-11-05 01:30:38 PST 
All reviewed patches have been landed.  Closing bug.