Bug 150698

Summary: Animometer computes frame rate incorrectly
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: Tools / TestsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, jonlee, lforschler, rniwa, sabouhallawa, simon.fraser
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Simon Fraser (smfr)
Reported 2015-10-29 16:22:56 PDT
The Animator.animate() function tests if (this._frameCount == this._dropFrameCount) before incrementing this._frameCount, causing it to store the wrong this._measureTimeOffset. This causes it to report 90fps when it's actually doing 60fps.
Attachments
Patch (1.88 KB, patch)
2015-10-29 17:26 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2015-10-29 17:26:43 PDT
Created attachment 264367 [details] Patch
Said Abou-Hallawa
Comment 2 2015-10-29 17:33:22 PDT
unofficial r=me.
WebKit Commit Bot
Comment 3 2015-10-29 18:29:12 PDT
Comment on attachment 264367 [details] Patch Clearing flags on attachment: 264367 Committed r191768: <http://trac.webkit.org/changeset/191768>
WebKit Commit Bot
Comment 4 2015-10-29 18:29:16 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.