Summary: | cdjs-tests.yaml/main.js.ftl fails due to FTL ArithSub code for supporting UntypedUse operands | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mark Lam <mark.lam> | ||||||
Component: | JavaScriptCore | Assignee: | Mark Lam <mark.lam> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | benjamin, commit-queue, fpizlo, ggaren, keith_miller, msaboff, saam | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Local Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 150562 | ||||||||
Attachments: |
|
Description
Mark Lam
2015-10-29 12:59:16 PDT
This issue is strictly in the FTL and 64-bit only. There were some 32-bit JSC bots that appeared to be failing due to this. That was due to a configuration bug on those bots where they were accidentally building 64-bit instead of 32-bit. That issue has been fixed in http://trac.webkit.org/changeset/191747. Created attachment 264336 [details]
patch to disable the feature.
Comment on attachment 264336 [details] patch to disable the feature. Rejecting attachment 264336 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 264336, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/Source/JavaScriptCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-queues.webkit.org/results/354537 Created attachment 264338 [details]
Fixed ChangeLog comment.
Comment on attachment 264338 [details] Fixed ChangeLog comment. Clearing flags on attachment: 264338 Committed r191753: <http://trac.webkit.org/changeset/191753> All reviewed patches have been landed. Closing bug. Disabling this optimization by checking the result type is super unusual and likely very fragile. Can you please use the use kinds instead? |