Bug 150633

Summary: Web Inspector: Timeline recording start button missing when WEB_REPLAY disabled (no ReplayAgent)
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2015-10-28 12:52:40 PDT
* SUMMARY Timeline recording start button missing when WEB_REPLAY disabled (no ReplayAgent). No replay agent was causing us to do: element.classList.toggle("foo", undefined) Which seems turns the class on. Correct this code to ensure we pass `false`.
Attachments
[PATCH] Proposed Fix (1.74 KB, patch)
2015-10-28 12:54 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-10-28 12:53:02 PDT
<rdar://problem/23301173>
Joseph Pecoraro
Comment 2 2015-10-28 12:54:57 PDT
Created attachment 264234 [details] [PATCH] Proposed Fix
Timothy Hatcher
Comment 3 2015-10-28 12:55:56 PDT
Comment on attachment 264234 [details] [PATCH] Proposed Fix Makes me wonder if we should audit all our classList.toggle calls.
WebKit Commit Bot
Comment 4 2015-10-28 13:42:44 PDT
Comment on attachment 264234 [details] [PATCH] Proposed Fix Clearing flags on attachment: 264234 Committed r191689: <http://trac.webkit.org/changeset/191689>
WebKit Commit Bot
Comment 5 2015-10-28 13:42:48 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.