Bug 150618

Summary: [SOUP] Cannot build the network process in glibc-based BSD systems
Product: WebKit Reporter: Alberto Garcia <berto>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, bugs-noreply, cgarcia, cmarcelo, commit-queue, lantw44
Priority: P2    
Version: Other   
Hardware: All   
OS: Other   
Attachments:
Description Flags
Patch cgarcia: review+

Alberto Garcia
Reported 2015-10-28 01:11:12 PDT
r184567 added support for st_birthtime in BSD systems. However this field is specific to the BSD libc, and therefore is not present on BSD systems that use the glibc, such as Debian GNU/kFreeBSD. Source/WebKit2/NetworkProcess/cache/NetworkCacheFileSystem.cpp: In function 'WebKit::NetworkCache::FileTimes WebKit::NetworkCache::fileTimes(const WTF::String&amp;)': Source/WebKit2/NetworkProcess/cache/NetworkCacheFileSystem.cpp:101:62: error: 'struct stat' has no member named 'st_birthtime' return { std::chrono::system_clock::from_time_t(fileInfo.st_birthtime), std::chrono::system_clock::from_time_t(fileInfo.st_mtime) }; ^
Attachments
Patch (947 bytes, patch)
2015-10-28 01:12 PDT, Alberto Garcia 		cgarcia: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alberto Garcia
Comment 1 2015-10-28 01:12:55 PDT
Created attachment 264200 [details] Patch
Alberto Garcia
Comment 2 2015-10-28 01:42:38 PDT
Committed r191662: <http://trac.webkit.org/changeset/191662>
Note You need to log in before you can comment on or make changes to this bug.