Bug 150605

Summary: Web Inspector: Remove unused / duplicated XHR timeline instrumentation
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: DoNotImportToRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2015-10-27 14:37:19 PDT
* SUMMARY Remove unused / duplicated XHR timeline instrumentation. There are two Timeline Events for XHRs (XHRReadyStateChange and XHRLoad) that are themselves unused. These Timeline Events are only ever created if there are Event Listeners, and always contain an "EventDispatch" record followed by "FunctionCall" meaning that the XHR records and their associated data is never actually used by the frontend. If we do something for XHRs, we should use a newer type of timeline data construction.
Attachments
[PATCH] Proposed Fix (20.17 KB, patch)
2015-10-27 14:40 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2015-10-27 14:40:00 PDT
Created attachment 264160 [details] [PATCH] Proposed Fix
WebKit Commit Bot
Comment 2 2015-10-27 15:08:50 PDT
Comment on attachment 264160 [details] [PATCH] Proposed Fix Clearing flags on attachment: 264160 Committed r191643: <http://trac.webkit.org/changeset/191643>
WebKit Commit Bot
Comment 3 2015-10-27 15:08:54 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.