Bug 150586

Summary: Add the support for Symbol attributes on IDL
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: BindingsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, saam, ysuzuki
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 150225    
Attachments:
Description Flags
Patch none

Ryosuke Niwa
Reported 2015-10-26 19:16:16 PDT
We need a mechanism to define a symbol attribute in IDL. e.g. Element.attributeChanged needs to be a symbol to support custom elements.
Attachments
Patch (10.78 KB, patch)
2015-10-31 06:49 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2015-10-26 19:52:14 PDT
My plan is, 1. introducing Symbol type into IDL CodeGenerator 2. implement attributeChanged as static attribute returning Symbol
Yusuke Suzuki
Comment 2 2015-10-31 06:49:55 PDT
Created attachment 264475 [details] Patch
Ryosuke Niwa
Comment 3 2015-10-31 06:51:26 PDT
Comment on attachment 264475 [details] Patch Thanks!
WebKit Commit Bot
Comment 4 2015-10-31 08:37:54 PDT
Comment on attachment 264475 [details] Patch Clearing flags on attachment: 264475 Committed r191841: <http://trac.webkit.org/changeset/191841>
WebKit Commit Bot
Comment 5 2015-10-31 08:37:58 PDT
All reviewed patches have been landed. Closing bug.
Yusuke Suzuki
Comment 6 2015-10-31 09:36:16 PDT
The tests failed, but it seems that this change is not relate to that. I guess the failures are caused due to Daylight Saving Time.
Note You need to log in before you can comment on or make changes to this bug.