Summary: | http/tests/contentextensions/async-xhr-onerror.html is flaky on mac-wk2 | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryan Haddad <ryanhaddad> | ||||||
Component: | WebKit Misc. | Assignee: | Alex Christensen <achristensen> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | achristensen, beidson, commit-queue | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Mac | ||||||||
OS: | Unspecified | ||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=146706 | ||||||||
Attachments: |
|
Description
Ryan Haddad
2015-10-26 15:33:09 PDT
Marked as flaky in <https://trac.webkit.org/r192059> Created attachment 264954 [details]
Patch
This should be landed along with marking the test as not flaky any more. Comment on attachment 264954 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=264954&action=review > Source/WebCore/xml/XMLHttpRequest.cpp:786 > + if (m_timeoutTimer.isActive()) > + m_timeoutTimer.stop(); Why do we need the "!isActive" check here? Calling stop should be harmless if the timer is not active. (In reply to comment #4) > Comment on attachment 264954 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=264954&action=review > > > Source/WebCore/xml/XMLHttpRequest.cpp:786 > > + if (m_timeoutTimer.isActive()) > > + m_timeoutTimer.stop(); > > Why do we need the "!isActive" check here? Calling stop should be harmless > if the timer is not active. It was done elsewhere in this file. I'll remove it elsewhere. Created attachment 265081 [details]
Patch
Comment on attachment 265081 [details] Patch Clearing flags on attachment: 265081 Committed r192175: <http://trac.webkit.org/changeset/192175> All reviewed patches have been landed. Closing bug. |