Bug 150576

Summary:

Make IDBKeyData from a struct to a class

Product:

WebKit

Reporter:

Brady Eidson <beidson>

Component:

WebCore Misc.

Assignee:

Brady Eidson <beidson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, alecflett, buildbot, commit-queue, jsbell, rniwa

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch v1	beidson: review-
Patch v2 - Including all the changes this time	none
Patch v3	buildbot: commit-queue-
Archive of layout-test-results from ews105 for mac-mavericks-wk2	none
Patch v4	buildbot: commit-queue-
Archive of layout-test-results from ews105 for mac-mavericks-wk2	none
Patch v5 - Piece of cake	achristensen: review+, beidson: commit-queue-
Archive of layout-test-results from ews107 for mac-mavericks-wk2	none
Patch v6 - for landing, after fixing boneheaded mistake	none

Brady Eidson

Reported 2015-10-26 15:15:48 PDT

Make IDBKeyData from a struct to a class.

Attachments
patch v1 (29.45 KB, patch) 2015-10-26 15:17 PDT, Brady Eidson	beidson: review-	Details Formatted Diff Diff
Patch v2 - Including all the changes this time (33.73 KB, patch) 2015-10-26 15:49 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Patch v3 (33.68 KB, patch) 2015-10-26 15:53 PDT, Brady Eidson	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews105 for mac-mavericks-wk2 (702.49 KB, application/zip) 2015-10-26 16:14 PDT, Build Bot	no flags	Details
Patch v4 (33.70 KB, patch) 2015-10-26 16:20 PDT, Brady Eidson	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews105 for mac-mavericks-wk2 (745.86 KB, application/zip) 2015-10-26 16:40 PDT, Build Bot	no flags	Details
Patch v5 - Piece of cake (33.76 KB, patch) 2015-10-26 16:47 PDT, Brady Eidson	achristensen: review+ beidson: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews107 for mac-mavericks-wk2 (1.05 MB, application/zip) 2015-10-26 17:40 PDT, Build Bot	no flags	Details
Patch v6 - for landing, after fixing boneheaded mistake (33.77 KB, patch) 2015-10-26 20:25 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Show Obsolete (8) View All Add attachment proposed patch, testcase, etc.

Brady Eidson

Comment 1 2015-10-26 15:17:18 PDT

Created attachment 264081 [details] patch v1

Brady Eidson

Comment 2 2015-10-26 15:49:16 PDT

Created attachment 264085 [details] Patch v2 - Including all the changes this time

Brady Eidson

Comment 3 2015-10-26 15:53:35 PDT

Created attachment 264087 [details] Patch v3

Build Bot

Comment 4 2015-10-26 16:14:28 PDT

Comment on attachment 264087 [details] Patch v3 Attachment 264087 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/341625 Number of test failures exceeded the failure limit.

Build Bot

Comment 5 2015-10-26 16:14:31 PDT

Created attachment 264090 [details] Archive of layout-test-results from ews105 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5

Brady Eidson

Comment 6 2015-10-26 16:20:12 PDT

Created attachment 264092 [details] Patch v4

Build Bot

Comment 7 2015-10-26 16:40:05 PDT

Comment on attachment 264092 [details] Patch v4 Attachment 264092 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/341709 Number of test failures exceeded the failure limit.

Build Bot

Comment 8 2015-10-26 16:40:07 PDT

Created attachment 264094 [details] Archive of layout-test-results from ews105 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5

Brady Eidson

Comment 9 2015-10-26 16:47:03 PDT

Created attachment 264095 [details] Patch v5 - Piece of cake

Build Bot

Comment 10 2015-10-26 17:40:39 PDT

Comment on attachment 264095 [details] Patch v5 - Piece of cake Attachment 264095 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/341885 Number of test failures exceeded the failure limit.

Build Bot

Comment 11 2015-10-26 17:40:41 PDT

Created attachment 264107 [details] Archive of layout-test-results from ews107 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5

Brady Eidson

Comment 12 2015-10-26 20:25:44 PDT

Created attachment 264116 [details] Patch v6 - for landing, after fixing boneheaded mistake

WebKit Commit Bot

Comment 13 2015-10-26 22:23:42 PDT

Comment on attachment 264116 [details] Patch v6 - for landing, after fixing boneheaded mistake Clearing flags on attachment: 264116 Committed r191620: <http://trac.webkit.org/changeset/191620>

WebKit Commit Bot

Comment 14 2015-10-26 22:23:47 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.