| Summary: | [Streams API] Add close method to writable stream | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Xabier Rodríguez Calvar <calvaris> | ||||||||||
| Component: | New Bugs | Assignee: | Xabier Rodríguez Calvar <calvaris> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | benjamin, commit-queue, darin, youennf | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Xabier Rodríguez Calvar
2015-10-26 09:56:12 PDT
Created attachment 264049 [details]
Patch
Comment on attachment 264049 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=264049&action=review > Source/WebCore/Modules/streams/StreamInternals.js:157 > + // TODO In this project we use FIXME. Lets not start also using TODO. Comment on attachment 264049 [details] Patch Attachment 264049 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/340553 New failing tests: streams/reference-implementation/writable-stream-abort.html Created attachment 264050 [details]
Archive of layout-test-results from ews114 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114 Port: mac-yosemite Platform: Mac OS X 10.10.5
Created attachment 264054 [details] Patch Flagged tests that are failing under certain conditions because of bug 147933 and turned TODOs into FIXMEs. (In reply to comment #5) > Flagged tests that are failing under certain conditions because of bug > 147933 and turned TODOs into FIXMEs. I think that flagging the offending tests would require a new r+. (In reply to comment #6) > (In reply to comment #5) > > Flagged tests that are failing under certain conditions because of bug > > 147933 and turned TODOs into FIXMEs. > > I think that flagging the offending tests would require a new r+. If Darin says nothing till tomorrow morning, I'll land this as the only change other than his suggestions is flagging the tests with the corresponding bug. Created attachment 264124 [details]
Patch for landing
Comment on attachment 264124 [details] Patch for landing Clearing flags on attachment: 264124 Committed r191622: <http://trac.webkit.org/changeset/191622> All reviewed patches have been landed. Closing bug. |