Summary: | [GTK] Allow applications to force Accelerated Compositing mode | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mario Sanchez Prada <mario> | ||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bugs-noreply, cgarcia, commit-queue, mcatanzaro, mrobinson, tpopela | ||||
Priority: | P2 | Keywords: | Gtk | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=154147 | ||||||
Attachments: |
|
Description
Mario Sanchez Prada
2015-10-26 09:25:06 PDT
(In reply to comment #0) > Originally proposed as a public API, that's perhaps too much, so perhaps > something simpler like recognizing a environment variable > WEBKIT_FORCE_ACCELERATED_COMPOSITING would be a better option. Wouldn't be better to use WEBKITGTK_ instead of WEBKIT_ as we are not the only WebKit port there.. (In reply to comment #1) > (In reply to comment #0) > > Originally proposed as a public API, that's perhaps too much, so perhaps > > something simpler like recognizing a environment variable > > WEBKIT_FORCE_ACCELERATED_COMPOSITING would be a better option. > > Wouldn't be better to use WEBKITGTK_ instead of WEBKIT_ as we are not the > only WebKit port there.. I don't have a strong opinion on this, but I think WEBKIT_ is the correct prefix here, as this causes a change in behaviour at the level of WebCore, I think, and not just in the port-specific bits. We already use WEBKIT for other thinks like WEBKIT_INSPECTOR_SERVER for example. I don't think that would conflict with any other port installed anyway, since you set the variable per program, but even if it's in your env, other ports will just ignore it. Created attachment 266764 [details]
Patch proposal
Attached patch proposal. I've tested this locally and seems to work as expected.
Please review, thanks!
Comment on attachment 266764 [details] Patch proposal Clearing flags on attachment: 266764 Committed r193626: <http://trac.webkit.org/changeset/193626> All reviewed patches have been landed. Closing bug. |